Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_multi_object_tracker): enable trigger publish when delay_compensation is false #8484

Conversation

technolojin
Copy link
Contributor

Description

Fix a bug that the object is not published when the option enable_delay_compensation is false.

Related links

Caused by PR tier4#1436

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin self-assigned this Aug 15, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 15, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 23.89%. Comparing base (3470824) to head (062826f).
Report is 6 commits behind head on main.

Files Patch % Lines
...i_object_tracker/src/multi_object_tracker_node.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8484      +/-   ##
==========================================
- Coverage   23.89%   23.89%   -0.01%     
==========================================
  Files        1380     1380              
  Lines      101835   101827       -8     
  Branches    38773    38764       -9     
==========================================
- Hits        24337    24333       -4     
+ Misses      75041    75031      -10     
- Partials     2457     2463       +6     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 23.89% <ø> (+<0.01%) ⬆️ Carriedforward from 58e0001

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it worked! LGTM

@technolojin technolojin merged commit c656530 into autowarefoundation:main Aug 15, 2024
38 of 39 checks passed
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
…_compensation is false (autowarefoundation#8484)

fix: enable trigger publish when delay_compensation is false

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
@technolojin technolojin deleted the fix/multi-object-tracker-publish-without-comp branch August 19, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants